Cleanup PR #69
Merged
Cleanup PR #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t differently depending on the function?
zain2864
approved these changes
Jan 14, 2025
|
|
||
| gen_json(logical_re, outfile, metadata ) | ||
| return cpt_trotter | ||
| logical_re = estimate_cpt_resources( |
There was a problem hiding this comment.
Here, I did some testing with using Trotter for Dynamics, if use_analytical = False, but given both value and reps, the value_per_t_gate is recorded as null. Is this the correct usage?
There was a problem hiding this comment.
this is a bug, great job finding it. Fixed with the latest update
src/qca/utils/utils.py
Outdated
| @@ -28,6 +29,7 @@ class EstimateMetaData: | |||
| is_extrapolated: bool=field(default=False, kw_only=True) | |||
| gate_synth_accuracy: int | float = field(default=10,kw_only=True) | |||
| value_per_circuit: float | None=field(default=None, kw_only=True) | |||
There was a problem hiding this comment.
are we keeping this as value_per_circuit, or just changing to value?
There was a problem hiding this comment.
Changed it to value
… trotterized subprocess gsee to AFTER we create circuit
…up some code to make sure we getting right value per t gate
zain2864
approved these changes
Jan 21, 2025
|
|
||
| def get_args(): | ||
| parser = ArgumentParser() | ||
| parser.add_argument('-l', '--lattice_size', type=int, help='Lattice size') |
There was a problem hiding this comment.
do we follow any convention here where the '-L' type of arguments should be capitalized? below in evolution time it is lowercase too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on cleaning up a bit of #68 and #65. Estimate resources handles gate accuracy differently when it comes to performing cpt transformations or through quatran manipulation, which wasn't totally clear. This resulted in negative resources when using the default argument, 10. The intended usage was to express it as 1e-10, but pyLIQTR does not handle it that way.
On top of those bug fixes, does some QOL changes for the scripts.
value_per_t_gate is handled better as well